Hisoka-X commented on code in PR #5476:
URL: https://github.com/apache/seatunnel/pull/5476#discussion_r1325781474
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-clickhouse-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ClickhouseIT.java:
##########
@@ -76,7 +76,7 @@
public class ClickhouseIT extends TestSuiteBase implements TestResource {
private static final Logger LOG =
LoggerFactory.getLogger(ClickhouseIT.class);
- private static final String CLICKHOUSE_DOCKER_IMAGE =
"yandex/clickhouse-server:22.1.3.7";
+ private static final String CLICKHOUSE_DOCKER_IMAGE =
"clickhouse/clickhouse-server:latest";
Review Comment:
I think @ruanwenjun means don't use `latest`, the version it represents can
be changed at any time. Just use a certain version.
> ClickhouseSinkCDCChangelogIT uses clickhouse/clickhouse-server:latest.
Should we unify it to yandex/clickhouse-server:22.1.3.7
Just unify use version which `clickhouse/clickhouse-server:latest`
represents. (Seem like is `23.3.13.6`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
