This is an automated email from the ASF dual-hosted git repository.

liugddx pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 31b375d3f4 [INFRA] Update PR template to add test and user change 
question (#5486)
31b375d3f4 is described below

commit 31b375d3f42136f3ab954fd55058799a6eada0ce
Author: Jia Fan <[email protected]>
AuthorDate: Mon Sep 18 15:13:16 2023 +0800

    [INFRA] Update PR template to add test and user change question (#5486)
    
    * [INFRA] Update PR template to add test and user change question
    
    * [INFRA] Update PR template to add test and user change question
    
    * update
---
 .github/PULL_REQUEST_TEMPLATE.md | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 2e7c09145f..d4a3001e52 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -16,13 +16,32 @@ Feel free to ping committers for the review!
 
 -->
 
-## Purpose of this pull request
+### Purpose of this pull request
 
 <!-- Describe the purpose of this pull request. For example: This pull request 
adds checkstyle plugin.-->
 
-## Check list
 
-* [ ] Code changed are covered with tests, or it does not need tests for 
reason:
+### Does this PR introduce _any_ user-facing change?
+<!--
+Note that it means *any* user-facing change including all aspects such as the 
documentation fix.
+If yes, please clarify the previous behavior and the change this PR proposes - 
provide the console output, description and/or an example to show the behavior 
difference if possible.
+If possible, please also clarify if this is a user-facing change compared to 
the released SeaTunnel versions or within the unreleased branches such as dev.
+If no, write 'No'.
+If you are adding/modifying connector documents, please follow our new 
specifications: https://github.com/apache/seatunnel/issues/4544.
+-->
+
+
+### How was this patch tested?
+<!--
+If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
+If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
+If tests were not added, please describe why they were not added and/or why it 
was difficult to add.
+If you are adding E2E test cases, maybe refer to 
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
 here is a good example.
+-->
+
+
+### Check list
+
 * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
   [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
 * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs

Reply via email to