Hisoka-X commented on code in PR #5508:
URL: https://github.com/apache/seatunnel/pull/5508#discussion_r1356118688
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/config/FileSinkConfig.java:
##########
@@ -83,7 +84,8 @@ public FileSinkConfig(@NonNull Config config, @NonNull
SeaTunnelRowType seaTunne
// if the config sink_columns is empty, all fields in
SeaTunnelRowTypeInfo will being write
if (CollectionUtils.isEmpty(this.sinkColumnList)) {
- this.sinkColumnList =
Arrays.asList(seaTunnelRowTypeInfo.getFieldNames());
+ this.sinkColumnList =
+ new
ArrayList<>(Arrays.asList(seaTunnelRowTypeInfo.getFieldNames()));
Review Comment:
Could you add some comment in here. Only read the code will confused
developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
