Carl-Zhou-CN commented on PR #5388: URL: https://github.com/apache/seatunnel/pull/5388#issuecomment-1759715240
> Over all looking great. But could you add some UT to cover some case? > > 1. User configure parameter in both url and properties with different key. > 2. User configure parameter in both url and properties with same key different value (also should metion it in the doc which value will be choose, I think the level of url should be higher). > 3. Only properties or only in url. > With these case, you should use UT to check the parameter result is you want. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
