Hisoka-X commented on code in PR #5628:
URL: https://github.com/apache/seatunnel/pull/5628#discussion_r1361413570


##########
docs/en/concept/schema-feature.md:
##########
@@ -24,6 +27,20 @@ schema = {
 }
 ```
 
+### table
+
+The table full name of the table identifier which the schema belongs to, it 
contains database, schema, table name. e.g. `database.schema.table`, 
`database.table`, `table`.
+
+### schemaFirst
+
+Default is false.
+
+If the schemaFirst is true, the schema will be used first, this means if we 
set `table = "a.b"`, a will be parsed as schema rather than database, then we 
can support write `table = "schema.table"`.

Review Comment:
   ```suggestion
   If the schema_first is true, the schema will be used first, this means if we 
set `table = "a.b"`, `a` will be parsed as schema rather than database, then we 
can support write `table = "schema.table"`.
   ```



##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/schema/TableSchemaOptions.java:
##########
@@ -28,6 +28,27 @@
 
 public class TableSchemaOptions {
 
+    public static class TableIdentifierOptions {
+
+        public static final Option<Boolean> SCHEMA_FIRST =

Review Comment:
   ditto



##########
docs/en/concept/schema-feature.md:
##########
@@ -24,6 +27,20 @@ schema = {
 }
 ```
 
+### table
+
+The table full name of the table identifier which the schema belongs to, it 
contains database, schema, table name. e.g. `database.schema.table`, 
`database.table`, `table`.
+
+### schemaFirst

Review Comment:
   For same config style.
   ```suggestion
   ### schema_first
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to