EricJoy2048 commented on code in PR #5450:
URL: https://github.com/apache/seatunnel/pull/5450#discussion_r1361488279
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -425,7 +425,7 @@ protected void tryTriggerPendingCheckpoint(CheckpointType
checkpointType) {
startTriggerPendingCheckpoint(pendingCheckpoint);
pendingCounter.incrementAndGet();
// if checkpoint type are final type, we don't need to trigger
next checkpoint
- if (checkpointType.notFinalCheckpoint() &&
checkpointType.notSchemaChangeCheckpoint()) {
Review Comment:
> why delete it？ @EricJoy2048
revert already.
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -425,7 +425,7 @@ protected void tryTriggerPendingCheckpoint(CheckpointType
checkpointType) {
startTriggerPendingCheckpoint(pendingCheckpoint);
pendingCounter.incrementAndGet();
// if checkpoint type are final type, we don't need to trigger
next checkpoint
- if (checkpointType.notFinalCheckpoint() &&
checkpointType.notSchemaChangeCheckpoint()) {
Review Comment:
> why delete it？ @EricJoy2048
revert already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
