hailin0 commented on code in PR #5614:
URL: https://github.com/apache/seatunnel/pull/5614#discussion_r1361860198
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/enumerator/SnapshotSplitAssigner.java:
##########
@@ -115,12 +120,12 @@ private SnapshotSplitAssigner(
this.context = context;
this.sourceConfig = context.getSourceConfig();
this.currentParallelism = currentParallelism;
- this.alreadyProcessedTables = alreadyProcessedTables;
- this.remainingSplits = remainingSplits;
- this.assignedSplits = assignedSplits;
- this.splitCompletedOffsets = splitCompletedOffsets;
+ this.alreadyProcessedTables =
Collections.synchronizedList(alreadyProcessedTables);
Review Comment:
CopyOnWriteArrayList is suitable for scenarios where there are very few
writes, because the copy action is expensive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
