ruanwenjun commented on code in PR #5632: URL: https://github.com/apache/seatunnel/pull/5632#discussion_r1363010616
########## seatunnel-dist/release-docs/licenses/LICENSE-jayway-jsonpath.txt: ########## @@ -0,0 +1,202 @@ + Review Comment: Following dependency is under Apache License 2, so this file is not needed, directly announce ``` listenablefuture-9999.0-empty-to-avoid-conflict-with-guava json-smart-2.4.7 accessors-smart-2.4.7 json-path-2.7.0 ``` in https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/release-docs/LICENSE asm-9.1.jar is under BSD 3-Clause you need to add asm license file https://asm.ow2.io/license.html ########## seatunnel-dist/release-docs/LICENSE: ########## @@ -275,6 +275,7 @@ The text of each license is the standard Apache 2.0 license. (Apache-2.0) listenablefuture (com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava https://mvnrepository.com/artifact/com.google.guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava) (Apache-2.0) accessors-smart (com.google.guava:accessors-smart:2.4.7 - https://mvnrepository.com/artifact/net.minidev/accessors-smart) (Apache-2.0) json-smart (net.minidev:json-smart:2.4.7 - https://mvnrepository.com/artifact/net.minidev/json-smart) + (Apache-2.0) json-path (com.jayway.jsonpath:json-path:2.7.0 - https://mvnrepository.com/artifact/com.jayway.jsonpath/json-path) Review Comment: Also need to announce following dependency in LICENSE ``` listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar json-smart-2.4.7.jar accessors-smart-2.4.7.jar asm-9.1.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
