Hisoka-X commented on code in PR #5255:
URL: https://github.com/apache/seatunnel/pull/5255#discussion_r1363082862


##########
docs/en/connector-v2/source/FakeSource.md:
##########
@@ -16,54 +16,53 @@ just for some test cases such as type conversion or 
connector new feature testin
 - [ ] [parallelism](../../concept/connector-v2-features.md)
 - [ ] [support user-defined split](../../concept/connector-v2-features.md)
 
-## Options
-
-|        name         |   type   | required |      default value      |
-|---------------------|----------|----------|-------------------------|
-| schema              | config   | yes      | -                       |
-| rows                | config   | no       | -                       |
-| row.num             | int      | no       | 5                       |
-| split.num           | int      | no       | 1                       |
-| split.read-interval | long     | no       | 1                       |
-| map.size            | int      | no       | 5                       |
-| array.size          | int      | no       | 5                       |
-| bytes.length        | int      | no       | 5                       |
-| string.length       | int      | no       | 5                       |
-| string.fake.mode    | string   | no       | range                   |
-| tinyint.fake.mode   | string   | no       | range                   |
-| tinyint.min         | tinyint  | no       | 0                       |
-| tinyint.max         | tinyint  | no       | 127                     |
-| tinyint.template    | list     | no       | -                       |
-| smallint.fake.mode  | string   | no       | range                   |
-| smallint.min        | smallint | no       | 0                       |
-| smallint.max        | smallint | no       | 32767                   |
-| smallint.template   | list     | no       | -                       |
-| int.fake.template   | string   | no       | range                   |
-| int.min             | int      | no       | 0                       |
-| int.max             | int      | no       | 0x7fffffff              |
-| int.template        | list     | no       | -                       |
-| bigint.fake.mode    | string   | no       | range                   |
-| bigint.min          | bigint   | no       | 0                       |
-| bigint.max          | bigint   | no       | 0x7fffffffffffffff      |
-| bigint.template     | list     | no       | -                       |
-| float.fake.mode     | string   | no       | range                   |
-| float.min           | float    | no       | 0                       |
-| float.max           | float    | no       | 0x1.fffffeP+127         |
-| float.template      | list     | no       | -                       |
-| double.fake.mode    | string   | no       | range                   |
-| double.min          | double   | no       | 0                       |
-| double.max          | double   | no       | 0x1.fffffffffffffP+1023 |
-| double.template     | list     | no       | -                       |
-| table-names         | list     | no       | -                       |
-| common-options      |          | no       | -                       |
-
-### schema [config]
-
-#### fields [Config]
-
-The schema of fake data that you want to generate
-
-#### Examples
+## Source Options
+
+|        Name         |   Type   | Required |         Default         |        
                                                                              
Description                                                                     
                 |
+|---------------------|----------|----------|-------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| schema              | config   | yes      | -                       | Define 
Schema information                                                              
                                                                                
               |
+| fields              | config   | yes      | -                       | Define 
Field information                                                               
                                                                                
               |

Review Comment:
   This is a sub config of `schema`. Not for `FakeSource` root config. Please 
refer 
https://github.com/apache/seatunnel/blob/dev/docs/en/concept/schema-feature.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to