hailin0 commented on code in PR #5663:
URL: https://github.com/apache/seatunnel/pull/5663#discussion_r1366386947
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSink.java:
##########
@@ -214,13 +215,14 @@ public void handleSaveMode(DataSaveMode saveMode) {
+ "."
+
CatalogUtils.quoteTableIdentifier(
jdbcSinkConfig.getTable(),
fieldIde));
- if (!catalog.databaseExists(jdbcSinkConfig.getDatabase()))
{
- catalog.createDatabase(tablePath, true);
- }
catalogTable.getOptions().put("fieldIde", fieldIde);
- if (!catalog.tableExists(tablePath)) {
- catalog.createTable(tablePath, catalogTable, true);
- }
+ return new DefaultSaveModeHandler(
Review Comment:
205 line：`try (Catalog catalog = catalogOptional.get()) {`
this code auto close catalog, Will savemode not interrupt abnormally?
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSink.java:
##########
@@ -214,13 +215,14 @@ public void handleSaveMode(DataSaveMode saveMode) {
+ "."
+
CatalogUtils.quoteTableIdentifier(
jdbcSinkConfig.getTable(),
fieldIde));
- if (!catalog.databaseExists(jdbcSinkConfig.getDatabase()))
{
- catalog.createDatabase(tablePath, true);
- }
catalogTable.getOptions().put("fieldIde", fieldIde);
- if (!catalog.tableExists(tablePath)) {
- catalog.createTable(tablePath, catalogTable, true);
- }
+ return new DefaultSaveModeHandler(
+ schemaSaveMode,
+ dataSaveMode,
+ catalog,
+ tablePath,
+ catalogTable,
+ config.get(JdbcOptions.CUSTOM_SQL));
} catch (UnsupportedOperationException | CatalogException e) {
// TODO Temporary fix, this feature has been changed in
this pr
// https://github.com/apache/seatunnel/pull/5645
Review Comment:
remove？
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSink.java:
##########
@@ -214,13 +215,14 @@ public void handleSaveMode(DataSaveMode saveMode) {
+ "."
+
CatalogUtils.quoteTableIdentifier(
jdbcSinkConfig.getTable(),
fieldIde));
- if (!catalog.databaseExists(jdbcSinkConfig.getDatabase()))
{
- catalog.createDatabase(tablePath, true);
- }
catalogTable.getOptions().put("fieldIde", fieldIde);
- if (!catalog.tableExists(tablePath)) {
- catalog.createTable(tablePath, catalogTable, true);
- }
+ return new DefaultSaveModeHandler(
+ schemaSaveMode,
+ dataSaveMode,
+ catalog,
+ tablePath,
+ catalogTable,
+ config.get(JdbcOptions.CUSTOM_SQL));
} catch (UnsupportedOperationException | CatalogException e) {
// TODO Temporary fix, this feature has been changed in
this pr
// https://github.com/apache/seatunnel/pull/5645
Review Comment:
remove？
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSink.java:
##########
@@ -214,13 +215,14 @@ public void handleSaveMode(DataSaveMode saveMode) {
+ "."
+
CatalogUtils.quoteTableIdentifier(
jdbcSinkConfig.getTable(),
fieldIde));
- if (!catalog.databaseExists(jdbcSinkConfig.getDatabase()))
{
- catalog.createDatabase(tablePath, true);
- }
catalogTable.getOptions().put("fieldIde", fieldIde);
- if (!catalog.tableExists(tablePath)) {
- catalog.createTable(tablePath, catalogTable, true);
- }
+ return new DefaultSaveModeHandler(
Review Comment:
205 line：`try (Catalog catalog = catalogOptional.get()) {`
this code auto close catalog, Will savemode not interrupt abnormally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
