Hisoka-X commented on code in PR #5542: URL: https://github.com/apache/seatunnel/pull/5542#discussion_r1366581778
########## seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ConnectorPackageServiceIT.java: ########## @@ -0,0 +1,148 @@ +/* Review Comment: I find all test case running on same JVM instance. It can't prove the upload logic work fine. Please add some e2e test case with 1 client and 2 server, all runnning on different docker containers. You can refer `org.apache.seatunnel.e2e.common.container.seatunnel.SeaTunnelContainer` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
