Hisoka-X commented on code in PR #5561:
URL: https://github.com/apache/seatunnel/pull/5561#discussion_r1366430631
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -48,19 +50,22 @@
import java.util.Objects;
@Slf4j
+@Setter
public class HttpSourceReader extends AbstractSingleSplitReader<SeaTunnelRow> {
protected final SingleSplitReaderContext context;
protected final HttpParameter httpParameter;
protected HttpClientProvider httpClient;
+ private final Configuration jsonConfiguration =
+ Configuration.defaultConfiguration().addOptions(DEFAULT_OPTIONS);
private final DeserializationCollector deserializationCollector;
private static final Option[] DEFAULT_OPTIONS = {
Option.SUPPRESS_EXCEPTIONS, Option.ALWAYS_RETURN_LIST,
Option.DEFAULT_PATH_LEAF_TO_NULL
};
private JsonPath[] jsonPaths;
private final JsonField jsonField;
private final String contentJson;
- private final Configuration jsonConfiguration =
- Configuration.defaultConfiguration().addOptions(DEFAULT_OPTIONS);
+ private Boolean noMoreElementFlag = true;
+ private PageInfo pageInfo;
Review Comment:
Use `Optional<PageInfo>` instead of `PageInfo` to avoid check `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
