ruanwenjun commented on code in PR #5683:
URL: https://github.com/apache/seatunnel/pull/5683#discussion_r1368086627
##########
seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/multitablesink/MultiTableWriterRunnable.java:
##########
@@ -62,7 +62,9 @@ public void run() {
writer.write(row);
}
} catch (Exception e) {
Review Comment:
```suggestion
} catch (InterruptedException e) {
// When the job finished, the thread will be interrupted,
so we ignore this exception.
throwable = e;
break;
} catch (Exception e) {
log.error("MultiTableWriterRunnable error", e);
throwable = e;
break;
}
```
##########
seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/multitablesink/MultiTableWriterRunnable.java:
##########
@@ -62,7 +62,9 @@ public void run() {
writer.write(row);
}
} catch (Exception e) {
Review Comment:
Can we catch this exception first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
