choucmei commented on code in PR #5560:
URL: https://github.com/apache/seatunnel/pull/5560#discussion_r1368532254
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcMysqlIT.java:
##########
@@ -242,61 +343,116 @@ Pair<String[], List<SeaTunnelRow>> initTestData() {
BigDecimal decimalValue = new
BigDecimal("999999999999999999999999999899");
for (int i = 0; i < 100; i++) {
byte byteArr = Integer.valueOf(i).byteValue();
- SeaTunnelRow row =
- new SeaTunnelRow(
- new Object[] {
- i % 2 == 0 ? (byte) 1 : (byte) 0,
- new byte[] {byteArr},
- new byte[] {byteArr, byteArr},
- new byte[] {byteArr, byteArr, byteArr,
byteArr},
- new byte[] {
- byteArr, byteArr, byteArr, byteArr,
byteArr, byteArr, byteArr,
- byteArr
- },
- i % 2 == 0 ? Boolean.TRUE : Boolean.FALSE,
- i,
- i,
- i,
- i,
- i,
- i,
- i,
- i,
- i,
- Long.parseLong("1"),
- Long.parseLong("1"),
- Long.parseLong("1"),
- BigDecimal.valueOf(i, 0),
- BigDecimal.valueOf(i, 18),
- BigDecimal.valueOf(i, 18),
- Float.parseFloat("1.1"),
- Float.parseFloat("1.1"),
- Double.parseDouble("1.1"),
- Double.parseDouble("1.1"),
- "f",
- String.format("f1_%s", i),
- String.format("f1_%s", i),
- String.format("f1_%s", i),
- String.format("f1_%s", i),
- String.format("{\"aa\":\"bb_%s\"}", i),
- String.format("f1_%s", i),
- Date.valueOf(LocalDate.now()),
- Timestamp.valueOf(LocalDateTime.now()),
- Time.valueOf(LocalTime.now()),
- new Timestamp(System.currentTimeMillis()),
- "test".getBytes(),
- "test".getBytes(),
- "test".getBytes(),
- "test".getBytes(),
- "test".getBytes(),
- "f".getBytes(),
- bigintValue.add(BigDecimal.valueOf(i)),
- decimalValue.add(BigDecimal.valueOf(i)),
- decimalValue.add(BigDecimal.valueOf(i)),
- });
+ SeaTunnelRow row;
+ if (i == 99) {
Review Comment:
Maybe should remove the if else and add null row outside the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
