hailin0 commented on code in PR #5572:
URL: https://github.com/apache/seatunnel/pull/5572#discussion_r1371107114
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/dm/DamengCatalog.java:
##########
@@ -46,14 +46,19 @@ public class DamengCatalog extends AbstractJdbcCatalog {
private static final String SELECT_COLUMNS_SQL =
"SELECT COLUMNS.COLUMN_NAME, COLUMNS.DATA_TYPE,
COLUMNS.DATA_LENGTH, COLUMNS.DATA_PRECISION, COLUMNS.DATA_SCALE "
- + ", COLUMNS.NULLABLE, COLUMNS.DATA_DEFAULT,
COMMENTS.COMMENTS "
+ + ", COLUMNS.NULLABLE, COLUMNS.DATA_DEFAULT,
COMMENTS.COMMENTS ,"
+ + "CASE \n"
+ + " WHEN COLUMNS.DATA_TYPE IN ('CHAR', 'CHARACTER',
'VARCHAR', 'VARCHAR2', 'VARBINARY', 'BINARY') THEN COLUMNS.DATA_TYPE || '(' ||
COLUMNS.DATA_LENGTH || ')'\n"
+ + " WHEN COLUMNS.DATA_TYPE IN ('NUMERIC',
'DECIMAL', 'NUMBER') AND COLUMNS.DATA_PRECISION IS NOT NULL AND
COLUMNS.DATA_SCALE IS NOT NULL AND COLUMNS.DATA_PRECISION != 0 AND
COLUMNS.DATA_SCALE != 0 THEN COLUMNS.DATA_TYPE || '(' || COLUMNS.DATA_PRECISION
|| ', ' || COLUMNS.DATA_SCALE || ')'\n"
+ + " ELSE COLUMNS.DATA_TYPE\n"
+ + " END AS SOURCE_TYPE \n"
+ "FROM ALL_TAB_COLUMNS COLUMNS "
+ "LEFT JOIN ALL_COL_COMMENTS COMMENTS "
+ "ON COLUMNS.OWNER = COMMENTS.SCHEMA_NAME "
+ "AND COLUMNS.TABLE_NAME = COMMENTS.TABLE_NAME "
+ "AND COLUMNS.COLUMN_NAME = COMMENTS.COLUMN_NAME "
- + "WHERE COLUMNS.OWNER = ? "
- + "AND COLUMNS.TABLE_NAME = ? "
+ + "WHERE COLUMNS.OWNER = '%s' "
+ + "AND COLUMNS.TABLE_NAME = '%s' "
Review Comment:
why change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
