Hisoka-X commented on code in PR #5702:
URL: https://github.com/apache/seatunnel/pull/5702#discussion_r1372665505
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java:
##########
@@ -57,6 +57,10 @@ public static void buildRequestParams(Map<String, String>
requestParams, String
} catch (IndexOutOfBoundsException e) {
throw new IllegalArgumentException("Invalid Params format in
Params.");
}
+ if
(Boolean.parseBoolean(requestParams.get(RestConstant.IS_START_WITH_SAVE_POINT))
+ && requestParams.get(RestConstant.JOB_ID) == null) {
+ throw new IllegalArgumentException("Please provide jobId when
start with save point.");
+ }
Review Comment:
Thanks @liunaijie for add this, could you add a test case for this too?
Please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
