ruanwenjun commented on code in PR #5721:
URL: https://github.com/apache/seatunnel/pull/5721#discussion_r1374371284
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/psql/PostgresCatalog.java:
##########
@@ -186,8 +188,44 @@ protected Column buildColumn(ResultSet resultSet) throws
SQLException {
}
@Override
- protected String getCreateTableSql(TablePath tablePath, CatalogTable
table) {
- return new PostgresCreateTableSqlBuilder(table).build(tablePath);
+ protected void createTableInternal(TablePath tablePath, CatalogTable table)
+ throws CatalogException {
+ PostgresCreateTableSqlBuilder postgresCreateTableSqlBuilder =
+ new PostgresCreateTableSqlBuilder(table);
+ String createTableSql = postgresCreateTableSqlBuilder.build(tablePath);
+ String dbUrl = getUrlFromDatabaseName(tablePath.getDatabaseName());
+ Connection conn = getConnection(dbUrl);
Review Comment:
Thanks for your reminder, update the code, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
