hailin0 commented on code in PR #5791:
URL: https://github.com/apache/seatunnel/pull/5791#discussion_r1384296741
##########
seatunnel-connectors-v2/connector-amazondynamodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/amazondynamodb/source/AmazonDynamoDBSourceReader.java:
##########
@@ -80,27 +77,27 @@ public void open() throws Exception {
}
@Override
- public void close() throws IOException {
+ public void close() {
dynamoDbClient.close();
}
@Override
@SuppressWarnings("magicnumber")
- public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
+ public void pollNext(Collector<SeaTunnelRow> output) {
while (!pendingSplits.isEmpty()) {
synchronized (output.getCheckpointLock()) {
AmazonDynamoDBSourceSplit split = pendingSplits.poll();
read(split, output);
}
}
- if (pendingSplits.isEmpty() && noMoreSplit) {
Review Comment:
Why delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
