Carl-Zhou-CN commented on code in PR #5617:
URL: https://github.com/apache/seatunnel/pull/5617#discussion_r1388812621
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/source/CoordinatedEnumeratorContext.java:
##########
@@ -47,11 +47,13 @@ public Set<Integer> registeredReaders() {
@Override
public void assignSplit(int subtaskId, List<SplitT> splits) {
+ // The Read that sends the current split to the current Task is used
for post-poll
coordinatedSource.addSplits(subtaskId, splits);
}
@Override
public void signalNoMoreSplits(int subtaskId) {
+ /* Notify the reader that there are no unassigned splits left */
Review Comment:
We can unify the style of interline comments and use "//" uniformly.
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/source/CoordinatedSource.java:
##########
@@ -47,18 +47,24 @@ public class CoordinatedSource<T, SplitT extends
SourceSplit, StateT extends Ser
implements BaseSourceFunction<T> {
protected static final long SLEEP_TIME_INTERVAL = 5L;
protected final SeaTunnelSource<T, SplitT, StateT> source;
+ // The subTask in the restored state corresponds to the corresponding
List<State>
protected final Map<Integer, List<byte[]>> restoredState;
protected final Integer parallelism;
protected final Serializer<SplitT> splitSerializer;
protected final Serializer<StateT> enumeratorStateSerializer;
+ /* The creation environment for the distribution read coordinator is used
to control split
+ distribution */
protected final CoordinatedEnumeratorContext<SplitT>
coordinatedEnumeratorContext;
protected final Map<Integer, CoordinatedReaderContext> readerContextMap;
+ // The task to be recovered and the corresponding split
protected final Map<Integer, List<SplitT>> restoredSplitStateMap = new
HashMap<>();
protected transient volatile SourceSplitEnumerator<SplitT, StateT>
splitEnumerator;
+ // the mapping is from subtask id to the reader info
Review Comment:
// The mapping is from subtask id to the reader info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
