Hisoka-X commented on code in PR #5828:
URL: https://github.com/apache/seatunnel/pull/5828#discussion_r1390097029
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java:
##########
@@ -173,64 +173,58 @@ private static CatalogTable getCatalogTable(
return jdbcCatalog.getTable(tableConfig.getQuery());
}
- private static CatalogTable mergeCatalogTable(
- CatalogTable tableOfPath, CatalogTable tableOfQuery) {
- String catalogName =
- tableOfQuery.getTableId() == null
- ? DEFAULT_CATALOG_NAME
- : tableOfQuery.getTableId().getCatalogName();
- TableIdentifier tableIdentifier =
- TableIdentifier.of(
- catalogName,
- tableOfPath.getTableId().getDatabaseName(),
- tableOfPath.getTableId().getSchemaName(),
- tableOfPath.getTableId().getTableName());
-
+ static CatalogTable mergeCatalogTable(CatalogTable tableOfPath,
CatalogTable tableOfQuery) {
Review Comment:
Please add @visiblefortesting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
