Hisoka-X commented on code in PR #5814:
URL: https://github.com/apache/seatunnel/pull/5814#discussion_r1390189669


##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleDataTypeConvertor.java:
##########
@@ -128,7 +128,6 @@ public SeaTunnelDataType<?> toSeaTunnelType(
             case ORACLE_XML:
                 return BasicType.STRING_TYPE;
             case ORACLE_DATE:
-                return LocalTimeType.LOCAL_DATE_TYPE;

Review Comment:
   It is compatible for the reading data end, but may not be compatible for the 
downstream writing data end because the data content has changed. But the 
purpose of this PR is to correct previous wrong behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to