This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 2233b3a381 [Improve] Rename `getCountSql` to `getExistDataSql` (#5838)
2233b3a381 is described below

commit 2233b3a3818a2c41f648263e66e67442c8387d6b
Author: Jia Fan <[email protected]>
AuthorDate: Wed Nov 15 17:20:07 2023 +0800

    [Improve] Rename `getCountSql` to `getExistDataSql` (#5838)
---
 .../connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java        | 4 ++--
 .../connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
index bb923f866d..3802a7a747 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
@@ -521,7 +521,7 @@ public abstract class AbstractJdbcCatalog implements 
Catalog {
         throw new UnsupportedOperationException();
     }
 
-    protected String getCountSql(TablePath tablePath) {
+    protected String getExistDataSql(TablePath tablePath) {
         throw new UnsupportedOperationException();
     }
 
@@ -539,7 +539,7 @@ public abstract class AbstractJdbcCatalog implements 
Catalog {
     public boolean isExistsData(TablePath tablePath) {
         String dbUrl = getUrlFromDatabaseName(tablePath.getDatabaseName());
         Connection connection = getConnection(dbUrl);
-        String sql = getCountSql(tablePath);
+        String sql = getExistDataSql(tablePath);
         try (PreparedStatement ps = connection.prepareStatement(sql)) {
             ResultSet resultSet = ps.executeQuery();
             return resultSet.next();
diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java
index 6bb1274a80..2ff7b399f3 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java
@@ -219,9 +219,9 @@ public class MySqlCatalog extends AbstractJdbcCatalog {
                 "TRUNCATE TABLE `%s`.`%s`;", tablePath.getDatabaseName(), 
tablePath.getTableName());
     }
 
-    public String getCountSql(TablePath tablePath) {
+    public String getExistDataSql(TablePath tablePath) {
         return String.format(
-                "select * from `%s`.`%s` limit 1;",
+                "SELECT * FROM `%s`.`%s` LIMIT 1;",
                 tablePath.getDatabaseName(), tablePath.getTableName());
     }
 }

Reply via email to