Hisoka-X commented on code in PR #5864:
URL: https://github.com/apache/seatunnel/pull/5864#discussion_r1398588732
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/utils/CatalogUtils.java:
##########
@@ -201,7 +205,7 @@ public static CatalogTable getCatalogTable(Connection
connection, TablePath tabl
catalogName);
}
- public static CatalogTable getCatalogTable(ResultSetMetaData
resultSetMetaData)
+ public static CatalogTable getCatalogTable(ResultSetMetaData
resultSetMetaData, String sqlQuery)
Review Comment:
I think error handling is also a very important part of the logic. If we
don't do this, we need to perform try catch everywhere where this method is
called, and then require the caller to return appropriate error information,
which is very unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
