xuqi1633 commented on code in PR #5904:
URL: https://github.com/apache/seatunnel/pull/5904#discussion_r1402864089
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceReader.java:
##########
@@ -60,25 +60,23 @@ public void close() throws IOException {
@Override
@SuppressWarnings("magicnumber")
public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
- synchronized (output.getCheckpointLock()) {
Review Comment:
Because the lock is acquired inside the output.collect() method, removing
the lock in the pollNext() method will not result in snapshot corruption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
