jackyyyyyssss commented on code in PR #5901:
URL: https://github.com/apache/seatunnel/pull/5901#discussion_r1403835119
##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java:
##########
@@ -50,57 +49,51 @@ public class RedisParameters implements Serializable {
private List<String> redisNodes = Collections.emptyList();
private long expire = RedisConfig.EXPIRE.defaultValue();
- public void buildWithConfig(Config config) {
+ public void buildWithConfig(ReadonlyConfig config) {
// set host
- this.host = config.getString(RedisConfig.HOST.key());
+ this.host = config.get(RedisConfig.HOST);
// set port
- this.port = config.getInt(RedisConfig.PORT.key());
- // set auth
- if (config.hasPath(RedisConfig.AUTH.key())) {
- this.auth = config.getString(RedisConfig.AUTH.key());
- }
+ this.port = config.get(RedisConfig.PORT);
// set db_num
- if (config.hasPath(RedisConfig.DB_NUM.key())) {
- this.dbNum = config.getInt(RedisConfig.DB_NUM.key());
+ this.dbNum = config.get(RedisConfig.DB_NUM);
+ // set auth
+ if (config.getOptional(RedisConfig.AUTH).isPresent()) {
+ this.auth = config.get(RedisConfig.AUTH);
}
// set user
- if (config.hasPath(RedisConfig.USER.key())) {
- this.user = config.getString(RedisConfig.USER.key());
+ if (config.getOptional(RedisConfig.USER).isPresent()) {
+ this.user = config.get(RedisConfig.USER);
}
// set mode
- if (config.hasPath(RedisConfig.MODE.key())) {
- this.mode =
- RedisConfig.RedisMode.valueOf(
-
config.getString(RedisConfig.MODE.key()).toUpperCase());
+ if (config.getOptional(RedisConfig.MODE).isPresent()) {
+ this.mode = config.get(RedisConfig.MODE);
} else {
this.mode = RedisConfig.MODE.defaultValue();
}
// set hash key mode
- if (config.hasPath(RedisConfig.HASH_KEY_PARSE_MODE.key())) {
- this.hashKeyParseMode =
- RedisConfig.HashKeyParseMode.valueOf(
-
config.getString(RedisConfig.HASH_KEY_PARSE_MODE.key()).toUpperCase());
+ if (config.getOptional(RedisConfig.HASH_KEY_PARSE_MODE).isPresent()) {
+ this.hashKeyParseMode =
config.get(RedisConfig.HASH_KEY_PARSE_MODE);
} else {
this.hashKeyParseMode =
RedisConfig.HASH_KEY_PARSE_MODE.defaultValue();
}
// set redis nodes information
- if (config.hasPath(RedisConfig.NODES.key())) {
- this.redisNodes = config.getStringList(RedisConfig.NODES.key());
+ if (config.getOptional(RedisConfig.NODES).isPresent()) {
+ this.redisNodes = config.get(RedisConfig.NODES);
}
// set key
- if (config.hasPath(RedisConfig.KEY.key())) {
- this.keyField = config.getString(RedisConfig.KEY.key());
+ if (config.getOptional(RedisConfig.KEY).isPresent()) {
+ this.keyField = config.get(RedisConfig.KEY);
}
// set keysPattern
- if (config.hasPath(RedisConfig.KEY_PATTERN.key())) {
- this.keysPattern = config.getString(RedisConfig.KEY_PATTERN.key());
+ if (config.getOptional(RedisConfig.KEY_PATTERN).isPresent()) {
+ this.keysPattern = config.get(RedisConfig.KEY_PATTERN);
}
- if (config.hasPath(RedisConfig.EXPIRE.key())) {
- this.expire = config.getLong(RedisConfig.EXPIRE.key());
+ if (config.getOptional(RedisConfig.EXPIRE).isPresent()) {
+ this.expire = config.get(RedisConfig.EXPIRE);
}
Review Comment:
thanks i know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
