(seatunnel) branch dev updated: [Fix] Fix flaky test `OptionUtilTest.test` (#5894)

[wanghailin]

This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new a6bd041dcc [Fix] Fix flaky test `OptionUtilTest.test` (#5894)
a6bd041dcc is described below

commit a6bd041dccb5e0442131d94c3715fea3a33d8c35
Author: Pritham Sriram Govindaraj <75803408+thugj...@users.noreply.github.com>
AuthorDate: Fri Nov 24 03:55:35 2023 -0600

    [Fix] Fix flaky test `OptionUtilTest.test` (#5894)
---
 .../api/configuration/util/OptionUtilTest.java     | 45 ++++++++++++----------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git 
a/seatunnel-api/src/test/java/org/apache/seatunnel/api/configuration/util/OptionUtilTest.java
 
b/seatunnel-api/src/test/java/org/apache/seatunnel/api/configuration/util/OptionUtilTest.java
index de9eec92a0..f009f7b327 100644
--- 
a/seatunnel-api/src/test/java/org/apache/seatunnel/api/configuration/util/OptionUtilTest.java
+++ 
b/seatunnel-api/src/test/java/org/apache/seatunnel/api/configuration/util/OptionUtilTest.java
@@ -22,6 +22,7 @@ import org.apache.seatunnel.api.configuration.Option;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import java.util.Comparator;
 import java.util.List;
 import java.util.Map;
 
@@ -30,38 +31,40 @@ public class OptionUtilTest {
     @Test
     public void test() throws InstantiationException, IllegalAccessException {
         List<Option<?>> options = 
OptionUtil.getOptions(TestOptionConfig.class);
-        Assertions.assertEquals("short-value", options.get(0).key());
-        Assertions.assertEquals("shortValue", options.get(0).getDescription());
-        Assertions.assertEquals(Short.class, 
options.get(0).typeReference().getType());
+        options.sort(Comparator.comparing(Option::key));
+        Assertions.assertEquals(Boolean.class, 
options.get(0).typeReference().getType());
+        Assertions.assertEquals(true, options.get(0).defaultValue());
 
-        Assertions.assertEquals(Integer.class, 
options.get(1).typeReference().getType());
-        Assertions.assertEquals("int_value", options.get(1).key());
-        Assertions.assertEquals("", options.get(1).getDescription());
-        Assertions.assertNull(options.get(1).defaultValue());
+        Assertions.assertEquals(Byte.class, 
options.get(1).typeReference().getType());
 
-        Assertions.assertEquals(Long.class, 
options.get(2).typeReference().getType());
+        Assertions.assertEquals(Character.class, 
options.get(2).typeReference().getType());
 
-        Assertions.assertEquals(Float.class, 
options.get(3).typeReference().getType());
+        Assertions.assertEquals(Double.class, 
options.get(3).typeReference().getType());
 
-        Assertions.assertEquals(Double.class, 
options.get(4).typeReference().getType());
+        Assertions.assertEquals(
+                TestOptionConfigEnum.class, 
options.get(4).typeReference().getType());
+        Assertions.assertEquals(TestOptionConfigEnum.KEY2, 
options.get(4).defaultValue());
 
-        Assertions.assertEquals(String.class, 
options.get(5).typeReference().getType());
-        Assertions.assertEquals("default string", 
options.get(5).defaultValue());
+        Assertions.assertEquals(Float.class, 
options.get(5).typeReference().getType());
 
-        Assertions.assertEquals(Boolean.class, 
options.get(6).typeReference().getType());
-        Assertions.assertEquals(true, options.get(6).defaultValue());
+        Assertions.assertEquals(Integer.class, 
options.get(6).typeReference().getType());
+        Assertions.assertEquals("int_value", options.get(6).key());
+        Assertions.assertEquals("", options.get(6).getDescription());
+        Assertions.assertNull(options.get(6).defaultValue());
 
-        Assertions.assertEquals(Byte.class, 
options.get(7).typeReference().getType());
+        Assertions.assertEquals(List.class, 
options.get(7).typeReference().getType());
 
-        Assertions.assertEquals(Character.class, 
options.get(8).typeReference().getType());
-        Assertions.assertEquals(
-                TestOptionConfigEnum.class, 
options.get(9).typeReference().getType());
-        Assertions.assertEquals(TestOptionConfigEnum.KEY2, 
options.get(9).defaultValue());
+        Assertions.assertEquals(Long.class, 
options.get(8).typeReference().getType());
+
+        Assertions.assertEquals(Map.class, 
options.get(9).typeReference().getType());
 
         Assertions.assertEquals(TestOptionConfig.class, 
options.get(10).typeReference().getType());
 
-        Assertions.assertEquals(List.class, 
options.get(11).typeReference().getType());
+        Assertions.assertEquals("short-value", options.get(11).key());
+        Assertions.assertEquals("shortValue", 
options.get(11).getDescription());
+        Assertions.assertEquals(Short.class, 
options.get(11).typeReference().getType());
 
-        Assertions.assertEquals(Map.class, 
options.get(12).typeReference().getType());
+        Assertions.assertEquals(String.class, 
options.get(12).typeReference().getType());
+        Assertions.assertEquals("default string", 
options.get(12).defaultValue());
     }
 }