This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new dcb4549109 [Improve][Zeta] Remove assert key words (#5947)
dcb4549109 is described below

commit dcb454910984a424761c64cd9ed6c9f4ea102166
Author: Chengyu Yan <[email protected]>
AuthorDate: Sat Dec 2 12:28:23 2023 +0800

    [Improve][Zeta] Remove assert key words (#5947)
---
 release-note.md                                                   | 1 +
 .../src/main/java/io/debezium/relational/TableId.java             | 4 ++--
 .../seatunnel/engine/server/checkpoint/CheckpointCoordinator.java | 8 +++++++-
 .../seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java | 1 -
 4 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/release-note.md b/release-note.md
index 147823065f..acfeb8fe8e 100644
--- a/release-note.md
+++ b/release-note.md
@@ -150,6 +150,7 @@
 - [Zeta] Improve Zeta operation max count and ignore NPE (#4787)
 - [Zeta] Remove serialize(deserialize) cost when use shuffle action (#4722)
 - [zeta] Checkpoint exception status messages exclude state data (#5547)
+- [Zeta] Remove assert key words (#5947)
 
 ## Feature
 
diff --git 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java
 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java
index eea2d050e9..09a8287684 100644
--- 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java
+++ 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java
@@ -20,6 +20,7 @@ package io.debezium.relational;
 import io.debezium.annotation.Immutable;
 import io.debezium.relational.Selectors.TableIdToStringMapper;
 import io.debezium.schema.DataCollectionId;
+import lombok.NonNull;
 
 import java.io.Serializable;
 
@@ -97,12 +98,11 @@ public final class TableId implements DataCollectionId, 
Comparable<TableId>, Ser
     public TableId(
             String catalogName,
             String schemaName,
-            String tableName,
+            @NonNull String tableName,
             TableIdToStringMapper tableIdMapper) {
         this.catalogName = catalogName;
         this.schemaName = schemaName;
         this.tableName = tableName;
-        assert this.tableName != null;
         this.id =
                 tableIdMapper == null
                         ? tableId(this.catalogName, this.schemaName, 
this.tableName)
diff --git 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
index 09bf416f6a..656dcf07eb 100644
--- 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
+++ 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
@@ -606,7 +606,13 @@ public class CheckpointCoordinator {
             long triggerTimestamp,
             CompletableFuture<Long> idFuture,
             CheckpointType checkpointType) {
-        assert Thread.holdsLock(lock);
+        if (!Thread.holdsLock(lock)) {
+            throw new RuntimeException(
+                    String.format(
+                            "Unsafe invoke, the current thread[%s] has not 
acquired the lock[%s].",
+                            Thread.currentThread().getName(), 
this.lock.toString()));
+        }
+
         latestTriggerTimestamp.set(triggerTimestamp);
         return idFuture.thenApplyAsync(
                         checkpointId ->
diff --git 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
index 9addb8d8ec..484482322c 100644
--- 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
+++ 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
@@ -133,7 +133,6 @@ public class RestHttpGetCommandProcessor extends 
HttpCommandProcessor<HttpGetCom
                                     } catch (InterruptedException | 
ExecutionException e) {
                                         logger.severe("get system monitoring 
information fail", e);
                                     }
-                                    assert input != null;
                                     String[] parts = input.split(", ");
                                     JsonObject jobInfo = new JsonObject();
                                     Arrays.stream(parts)

Reply via email to