TyrantLucifer commented on code in PR #5100:
URL: https://github.com/apache/seatunnel/pull/5100#discussion_r1413568517
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SourceExecuteProcessor.java:
##########
@@ -76,24 +67,14 @@ public List<DataStreamTableInfo>
execute(List<DataStreamTableInfo> upstreamDataS
SourceTableInfo sourceTableInfo = plugins.get(i);
SeaTunnelSource internalSource = sourceTableInfo.getSource();
Config pluginConfig = pluginConfigs.get(i);
- BaseSeaTunnelSourceFunction sourceFunction;
if (internalSource instanceof SupportCoordinate) {
- sourceFunction = new
SeaTunnelCoordinatedSource(internalSource, envConfigs);
-
registerAppendStream(pluginConfig);
- } else {
- sourceFunction = new SeaTunnelParallelSource(internalSource,
envConfigs);
}
- boolean bounded =
- internalSource.getBoundedness()
- ==
org.apache.seatunnel.api.source.Boundedness.BOUNDED;
+ FlinkSource flinkSource = new FlinkSource<>(internalSource);
- DataStreamSource<Row> sourceStream =
- addSource(
- executionEnvironment,
- sourceFunction,
- "SeaTunnel " +
internalSource.getClass().getSimpleName(),
- bounded);
+ DataStreamSource sourceStream =
+ executionEnvironment.fromSource(
+ flinkSource, WatermarkStrategy.noWatermarks(),
"st-source");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
