CheneyYin commented on code in PR #5948:
URL: https://github.com/apache/seatunnel/pull/5948#discussion_r1418827419
##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonDeserializationSchema.java:
##########
@@ -148,31 +155,25 @@ public SeaTunnelRow convertToRowData(JsonNode message) {
return (SeaTunnelRow) runtimeConverter.convert(message);
}
- private JsonNode convertBytes(byte[] message) {
+ private JsonNode convertMayIgnoreError(byte[] message) {
Review Comment:
ACK.
But `convertBytes` and `convert` have similar functions, with different
parameter types. `convertBytes` suffix `bytes`, which is obviously redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
