hellof3 commented on code in PR #6009:
URL: https://github.com/apache/seatunnel/pull/6009#discussion_r1432283222
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/AbstractReadStrategy.java:
##########
@@ -89,34 +90,36 @@ boolean checkFileType(String path) {
@Override
public List<String> getFileNamesByPath(String path) throws IOException {
+ ArrayList<String> fileNames = new ArrayList<>();
+ Path basePath = new Path(path);
+ if (readPartitions.isEmpty()) {
+ fileNames.addAll(getFileNamesByPath(basePath));
+ } else {
+ for (String readPartition : readPartitions) {
+ fileNames.addAll(getFileNamesByPath(new Path(basePath,
readPartition)));
+ }
Review Comment:
I think if you have multi partitions, the partition name should be written
in full. There is no 'age=11' partition. We can support wildcard matching,
which can be written as 'location=\*/age=11' or '\*/age=11'. What do you think?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
