Hisoka-X commented on code in PR #6084:
URL: https://github.com/apache/seatunnel/pull/6084#discussion_r1436760245
##########
seatunnel-connectors-v2/connector-file/connector-file-ftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/ftp/config/FtpConfigOptions.java:
##########
@@ -36,4 +36,9 @@ public class FtpConfigOptions extends BaseSourceConfigOptions
{
Options.key("host").stringType().noDefaultValue().withDescription("FTP server
host");
public static final Option<Integer> FTP_PORT =
Options.key("port").intType().noDefaultValue().withDescription("FTP server
port");
+ public static final Option<Boolean> FTP_ACTIVE_MODE_STATUS =
+ Options.key("active_mode_status")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription("FTP server mode default active");
Review Comment:
I think we should use enum to support 4 type mode.
Not only `true` or `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
