Hisoka-X commented on code in PR #6099:
URL: https://github.com/apache/seatunnel/pull/6099#discussion_r1437349909
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseFileSinkConfig.java:
##########
@@ -71,6 +72,10 @@ public BaseFileSinkConfig(@NonNull Config config) {
}
checkNotNull(path);
+ if (path.equals(File.separator)) {
+ this.path = "";
+ }
Review Comment:
what's this use for?
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-ftp-e2e/src/test/resources/excel/fake_source_to_ftp_excel.conf:
##########
@@ -81,5 +81,6 @@ sink {
file_format_type = "excel"
filename_time_format = "yyyy.MM.dd"
is_enable_transaction = true
+ connection_mode=active_local
Review Comment:
since the default value is `active_local`. So I think we can remove it from
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
