liugddx commented on code in PR #6081:
URL: https://github.com/apache/seatunnel/pull/6081#discussion_r1437942002


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java:
##########
@@ -159,6 +166,19 @@ private void getSystemMonitoringInformation(HttpGetCommand 
command) {
         this.prepareResponse(command, jsonValues);
     }
 
+    private void handleLog(HttpGetCommand command) throws IOException {
+
+        String logPath = System.getProperty("seatunnel.logs.path");
+        String logName = System.getProperty("seatunnel.logs.file_name") + 
".log";

Review Comment:
   > Why not use config in ${SEATUNNEL_HOME}/config/log4j2.properties to get 
file path? Declaring the log path with different keys in different places will 
increase maintenance costs. 
   
   How to get this? Can you elaborate?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to