Hisoka-X commented on code in PR #6114:
URL: https://github.com/apache/seatunnel/pull/6114#discussion_r1439120962
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -442,6 +442,7 @@ public PassiveCompletableFuture<Void> submitJob(long jobId,
Data jobImmutableInf
runningJobInfoIMap.remove(jobId);
runningJobMasterMap.remove(jobId);
}
+ jobMaster.setClassLoader(null);
Review Comment:
I'm not sure if this method is reasonable, because `JobMaster` will be
cleaned up from `runningJobMasterMap` when the job ends, which means that
`JobMaster` will not be referenced after that, and his member variable
`classloader` will not be referenced, so then It can be recycled normally. Can
you tell me the deeper reason for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
