EricJoy2048 commented on code in PR #5514:
URL: https://github.com/apache/seatunnel/pull/5514#discussion_r1442568552
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseFileSinkConfig.java:
##########
@@ -100,10 +102,6 @@ public BaseFileSinkConfig(@NonNull Config config) {
timeFormat =
TimeUtils.Formatter.parse(config.getString(BaseSinkConfig.TIME_FORMAT.key()));
}
-
- if (config.hasPath(BaseSinkConfig.ENABLE_HEADER_WRITE.key())) {
Review Comment:
Why remove this?
##########
docs/en/connector-v2/sink/Hive.md:
##########
@@ -25,21 +25,24 @@ By default, we use 2PC commit to ensure `exactly-once`
- [x] parquet
- [x] orc
- [x] json
+ - [x] hive_text : support the text storage format of hive collection data
type, array, map, struct.
Review Comment:
`hive_text` is not a file format, can not put it here. You can use example
to tell uses how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
