EricJoy2048 commented on code in PR #6131:
URL: https://github.com/apache/seatunnel/pull/6131#discussion_r1442582374
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -241,6 +246,22 @@ When File Format is Excel,The maximum number of data items
that can be cached in
Writer the sheet of the workbook
+### schema_save_mode[Enum]
+
+Before turning on the synchronous task, do different treatment of the target
path.
+Option introduction：
+`RECREATE_SCHEMA` ：Will create when the path does not exist, delete and
rebuild when the path is saved
Review Comment:
```suggestion
`RECREATE_SCHEMA` ：Will be created when the path does not exist. If the path
already exists, delete the path and recreate it.
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -241,6 +246,22 @@ When File Format is Excel,The maximum number of data items
that can be cached in
Writer the sheet of the workbook
+### schema_save_mode[Enum]
+
+Before turning on the synchronous task, do different treatment of the target
path.
+Option introduction：
+`RECREATE_SCHEMA` ：Will create when the path does not exist, delete and
rebuild when the path is saved
+`CREATE_SCHEMA_WHEN_NOT_EXIST` ：Will Created when the path does not exist,
skipped when the path is saved
Review Comment:
```suggestion
`CREATE_SCHEMA_WHEN_NOT_EXIST` ：Will Created when the path does not exist,
use the path when the path is exist.
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -241,6 +246,22 @@ When File Format is Excel,The maximum number of data items
that can be cached in
Writer the sheet of the workbook
+### schema_save_mode[Enum]
+
+Before turning on the synchronous task, do different treatment of the target
path.
+Option introduction：
+`RECREATE_SCHEMA` ：Will create when the path does not exist, delete and
rebuild when the path is saved
+`CREATE_SCHEMA_WHEN_NOT_EXIST` ：Will Created when the path does not exist,
skipped when the path is saved
+`ERROR_WHEN_SCHEMA_NOT_EXIST` ：Error will be reported when the path does not
exist
+
+### data_save_mode[Enum]
+
+Before opening the synchronous task, the data file in the target path is
differently processed.
+Option introduction：
+`DROP_DATA`： Preserve path structure and delete data
+`APPEND_DATA`：Preserve path structure, preserve data
+`ERROR_WHEN_DATA_EXISTS`：When there is data, an error is reported
Review Comment:
```suggestion
`ERROR_WHEN_DATA_EXISTS`：When there are some data files in the path, an
error will reported.
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -241,6 +246,22 @@ When File Format is Excel,The maximum number of data items
that can be cached in
Writer the sheet of the workbook
+### schema_save_mode[Enum]
+
+Before turning on the synchronous task, do different treatment of the target
path.
+Option introduction：
+`RECREATE_SCHEMA` ：Will create when the path does not exist, delete and
rebuild when the path is saved
+`CREATE_SCHEMA_WHEN_NOT_EXIST` ：Will Created when the path does not exist,
skipped when the path is saved
+`ERROR_WHEN_SCHEMA_NOT_EXIST` ：Error will be reported when the path does not
exist
+
+### data_save_mode[Enum]
+
+Before opening the synchronous task, the data file in the target path is
differently processed.
+Option introduction：
+`DROP_DATA`： Preserve path structure and delete data
Review Comment:
```suggestion
`DROP_DATA`： use the path but delete data files in the path.
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -383,6 +404,8 @@ For orc file format simple config with
`org.apache.hadoop.fs.s3a.SimpleAWSCreden
access_key = "xxxxxxxxxxxxxxxxx"
secret_key = "xxxxxxxxxxxxxxxxx"
file_format_type = "orc"
+ schema_save_mode = "CREATE_SCHEMA_WHEN_NOT_EXIST"
Review Comment:
Please add examples for `Multiple Table Writes`
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -241,6 +246,22 @@ When File Format is Excel,The maximum number of data items
that can be cached in
Writer the sheet of the workbook
+### schema_save_mode[Enum]
+
+Before turning on the synchronous task, do different treatment of the target
path.
+Option introduction：
+`RECREATE_SCHEMA` ：Will create when the path does not exist, delete and
rebuild when the path is saved
+`CREATE_SCHEMA_WHEN_NOT_EXIST` ：Will Created when the path does not exist,
skipped when the path is saved
+`ERROR_WHEN_SCHEMA_NOT_EXIST` ：Error will be reported when the path does not
exist
+
+### data_save_mode[Enum]
+
+Before opening the synchronous task, the data file in the target path is
differently processed.
+Option introduction：
+`DROP_DATA`： Preserve path structure and delete data
+`APPEND_DATA`：Preserve path structure, preserve data
Review Comment:
```suggestion
`APPEND_DATA`：use the path, and add new files in the path for write datas.
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -117,7 +117,12 @@ If write to `csv`, `text` file type, All column will be
string.
| max_rows_in_memory | int | no | -
| Only used when file_format is excel.
|
| sheet_name | string | no | Sheet${Random
number} | Only used when file_format is excel.
|
| hadoop_s3_properties | map | no |
| If you need to add a other option, you could
add it here and refer to this
[link](https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/index.html)
|
-| |
+| schema_save_mode | Enum | no |
CREATE_SCHEMA_WHEN_NOT_EXIST | Before turning on the
synchronous task, do different treatment of the target path
|
+| data_save_mode | Enum | no | APPEND_DATA
| Before opening the synchronous task, the
data file in the target path is differently processed
|
+
+### path [string]
+
+Store the path of the data file to support variable replacement. For example:
path=/test/${database_name}/${schema_name}/${table_name}
Review Comment:
Please add examples for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
