EricJoy2048 commented on code in PR #6029:
URL: https://github.com/apache/seatunnel/pull/6029#discussion_r1444460479
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/config/StarRocksSinkOptions.java:
##########
@@ -131,10 +129,15 @@ public interface StarRocksSinkOptions {
.enumType(StreamLoadFormat.class)
.defaultValue(StreamLoadFormat.JSON)
.withDescription("");
-
- SingleChoiceOption<DataSaveMode> SAVE_MODE =
- Options.key(SupportSaveMode.DATA_SAVE_MODE_KEY)
- .singleChoice(DataSaveMode.class,
Arrays.asList(DataSaveMode.APPEND_DATA))
+ Option<SchemaSaveMode> SCHEMA_SAVE_MODE =
+ Options.key("schema_save_mode")
+ .enumType(SchemaSaveMode.class)
+ .defaultValue(SchemaSaveMode.CREATE_SCHEMA_WHEN_NOT_EXIST)
+ .withDescription("schema_save_mode");
Review Comment:
> I hope there is a more detailed description
Yes, only copy the option name to here doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
