Carl-Zhou-CN commented on code in PR #6076:
URL: https://github.com/apache/seatunnel/pull/6076#discussion_r1445575666


##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/utils/RowConverter.java:
##########
@@ -381,9 +386,13 @@ public static InternalRow convert(
                     break;
                 case DATE:
                     LocalDate date = (LocalDate) seaTunnelRow.getField(i);
-                    LocalTime time = LocalTime.of(0, 0, 0);
-                    binaryWriter.writeTimestamp(
-                            i, Timestamp.fromLocalDateTime(date.atTime(time)), 
3);
+                    String dateStr = 
date.format(DateTimeFormatter.ofPattern("yyyy-MM-dd"));

Review Comment:
   Wouldn't it be more convenient to directly obtain the number of days from 
LocalDate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to