Hisoka-X commented on code in PR #6176:
URL: https://github.com/apache/seatunnel/pull/6176#discussion_r1447094147
##########
docs/en/connector-v2/sink/Oracle.md:
##########
@@ -74,10 +74,11 @@ semantics (using XA transaction guarantee).
| transaction_timeout_sec | Int | No | -1
| The timeout after the transaction is opened, the default is
-1 (never timeout). Note that setting the timeout may affect<br/>exactly-once
semantics
|
| auto_commit | Boolean | No | true
| Automatic transaction commit is enabled by default
|
| properties | Map | No | -
| Additional connection configuration parameters,when
properties and URL have the same parameters, the priority is determined by the
<br/>specific implementation of the driver. For example, in MySQL, properties
take precedence over the URL. |
-| common-options | | no | -
| Sink plugin common parameters, please refer to [Sink Common
Options](common-options.md) for details
|
-| schema_save_mode | Enum | no |
CREATE_SCHEMA_WHEN_NOT_EXIST | Before the synchronous task is turned on,
different treatment schemes are selected for the existing surface structure of
the target side.
|
-| data_save_mode | Enum | no | APPEND_DATA
| Before the synchronous task is turned on, different
processing schemes are selected for data existing data on the target side.
|
-| custom_sql | String | no | -
| When data_save_mode selects CUSTOM_PROCESSING, you should
fill in the CUSTOM_SQL parameter. This parameter usually fills in a SQL that
can be executed. SQL will be executed before synchronization tasks.
|
+| common-options | | No | -
| Sink plugin common parameters, please refer to [Sink Common
Options](common-options.md) for details
|
+| schema_save_mode | Enum | No |
CREATE_SCHEMA_WHEN_NOT_EXIST | Before the synchronous task is turned on,
different treatment schemes are selected for the existing surface structure of
the target side.
|
+| data_save_mode | Enum | No | APPEND_DATA
| Before the synchronous task is turned on, different
processing schemes are selected for data existing data on the target side.
|
+| custom_sql | String | No | -
| When data_save_mode selects CUSTOM_PROCESSING, you should
fill in the CUSTOM_SQL parameter. This parameter usually fills in a SQL that
can be executed. SQL will be executed before synchronization tasks.
|
+| enable_upsert | Boolean | No | true
|
|
Review Comment:
ditto
##########
docs/en/connector-v2/sink/Mysql.md:
##########
@@ -80,10 +80,11 @@ semantics (using XA transaction guarantee).
| auto_commit | Boolean | No | true
| Automatic transaction commit is enabled by default
|
| field_ide | String | No | -
| Identify whether the field needs to be converted when
synchronizing from the source to the sink. `ORIGINAL` indicates no conversion
is needed;`UPPERCASE` indicates conversion to uppercase;`LOWERCASE` indicates
conversion to lowercase. |
| properties | Map | No | -
| Additional connection configuration parameters,when
properties and URL have the same parameters, the priority is determined by the
<br/>specific implementation of the driver. For example, in MySQL, properties
take precedence over the URL. |
-| common-options | | no | -
| Sink plugin common parameters, please refer to [Sink Common
Options](common-options.md) for details
|
-| schema_save_mode | Enum | no |
CREATE_SCHEMA_WHEN_NOT_EXIST | Before the synchronous task is turned on,
different treatment schemes are selected for the existing surface structure of
the target side.
|
-| data_save_mode | Enum | no | APPEND_DATA
| Before the synchronous task is turned on, different
processing schemes are selected for data existing data on the target side.
|
-| custom_sql | String | no | -
| When data_save_mode selects CUSTOM_PROCESSING, you should
fill in the CUSTOM_SQL parameter. This parameter usually fills in a SQL that
can be executed. SQL will be executed before synchronization tasks.
|
+| common-options | | No | -
| Sink plugin common parameters, please refer to [Sink Common
Options](common-options.md) for details
|
+| schema_save_mode | Enum | No |
CREATE_SCHEMA_WHEN_NOT_EXIST | Before the synchronous task is turned on,
different treatment schemes are selected for the existing surface structure of
the target side.
|
+| data_save_mode | Enum | No | APPEND_DATA
| Before the synchronous task is turned on, different
processing schemes are selected for data existing data on the target side.
|
+| custom_sql | String | No | -
| When data_save_mode selects CUSTOM_PROCESSING, you should
fill in the CUSTOM_SQL parameter. This parameter usually fills in a SQL that
can be executed. SQL will be executed before synchronization tasks.
|
+| enable_upsert | Boolean | No | true
|
|
Review Comment:
miss description.
##########
docs/en/connector-v2/sink/Jdbc.md:
##########
@@ -186,10 +187,14 @@ Option introduction：
`CUSTOM_PROCESSING`：User defined processing
`ERROR_WHEN_DATA_EXISTS`：When there is data, an error is reported
-### custom_sql[String]
+### custom_sql [String]
When data_save_mode selects CUSTOM_PROCESSING, you should fill in the
CUSTOM_SQL parameter. This parameter usually fills in a SQL that can be
executed. SQL will be executed before synchronization tasks.
+### enable_upsert [boolean]
+
+Enable upsert by primary_keys exist, If the task only has `insert`, setting
this parameter to `false` can speed up data import
Review Comment:
PTAL @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
