EricJoy2048 commented on code in PR #5453:
URL: https://github.com/apache/seatunnel/pull/5453#discussion_r1450073880
##########
docs/en/connector-v2/sink/common-options.md:
##########
@@ -2,24 +2,15 @@
> Common parameters of sink connectors
-| name | type | required | default value |
-|-------------------|--------|----------|---------------|
-| source_table_name | string | no | - |
-| parallelism | int | no | - |
+| Name | Type | Required | Default |
Description
|
+|-------------------|--------|----------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| source_table_name | String | No | - | When `source_table_name`
is not specified, the current plug-in processes the data set `dataset` output
by the previous plugin in the configuration file <br/> When `source_table_name`
is specified, the current plug-in is processing the data set corresponding to
this parameter. |
Review Comment:
Some important caveat should be added: `source_table_name` and
`result_table_name` are only used to represent the upstream and downstream
relationships of the connector. They should not be treated as in-memory
datasets. No data is stored in them.
##########
docs/en/transform-v2/common-options.md:
##########
@@ -1,23 +1,65 @@
# Transform Common Options
-> Common parameters of source connectors
+> This is a process of intermediate conversion between the source and sink
terminals,You can use sql statements to smoothly complete the conversion process
-| name | type | required | default value |
-|-------------------|--------|----------|---------------|
-| result_table_name | string | no | - |
-| source_table_name | string | no | - |
+| Name | Type | Required | Default |
Description
|
+|-------------------|--------|----------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| result_table_name | String | No | - | When `source_table_name`
is not specified, the current plug-in processes the data set `(dataset)` output
by the previous plug-in in the configuration file; <br/>When
`source_table_name` is specified, the current plugin is processing the data set
corresponding to this parameter.
|
Review Comment:
same as above.
##########
docs/en/connector-v2/source/common-options.md:
##########
@@ -2,32 +2,76 @@
> Common parameters of source connectors
-| name | type | required | default value |
-|-------------------|--------|----------|---------------|
-| result_table_name | string | no | - |
-| parallelism | int | no | - |
+| Name | Type | Required | Default |
Description
|
+|-------------------|--------|----------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| result_table_name | String | No | - | When `result_table_name`
is not specified, the data processed by this plugin will not be registered as a
data set `(dataStream/dataset)` that can be directly accessed by other plugins,
or called a temporary table `(table)` <br/>When `result_table_name` is
specified, the data processed by this plugin will be registered as a data set
`(dataStream/dataset)` that can be directly accessed by other plugins, or
called a temporary table `(table)` . The data set `(dataStream/dataset)`
registered here can be directly accessed by other plugins by specifying
`source_table_name` . |
Review Comment:
same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
