Hisoka-X commented on code in PR #6250:
URL: https://github.com/apache/seatunnel/pull/6250#discussion_r1462656968
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-rocketmq-e2e/src/test/java/org/apache/seatunnel/e2e/connector/rocketmq/RocketMqIT.java:
##########
@@ -214,6 +214,21 @@ public void testSourceRocketMqTextToConsole(TestContainer
container)
Assertions.assertEquals(0, execResult.getExitCode(),
execResult.getStderr());
}
+ @TestTemplate
+ public void testStreamingSourceRocketMqTextToConsole(TestContainer
container)
Review Comment:
Thanks @cqutwangyu for updated the test case! There are still some code
should be changed. Because we create an streaming job. So I think it will never
return exit code if executed normally. I think you should async run
`executeJob`, then sleep main thread more than 60s. Finally check the job still
running.
eg:
```java
CompletableFuture future = CompletableFuture.supplyAsync(
() -> {
try {
container.executeJob("/rocketmq-source_streaming_text_to_console.conf");
} catch (Exception e) {
log.error("Commit task exception :" + e.getMessage());
throw new RuntimeException(e);
}
return null;
});
Thread.sleep(60 * 1000);
// meaning job still running
Assertions.assertFalse(future.isDone());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
