(seatunnel) branch dev updated: [Fix][Connector-V2] Fix mongodb cdc start up mode option values not right (#6338)

[wenjun]

This is an automated email from the ASF dual-hosted git repository.

wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new c07f56fbc4 [Fix][Connector-V2] Fix mongodb cdc start up mode option 
values not right (#6338)
c07f56fbc4 is described below

commit c07f56fbc49bca3066f2d860748ff6fff1d8d9c5
Author: Jia Fan <fanjiaemi...@qq.com>
AuthorDate: Fri Feb 23 18:50:11 2024 +0800

    [Fix][Connector-V2] Fix mongodb cdc start up mode option values not right 
(#6338)
---
 .../cdc/mongodb/config/MongodbSourceOptions.java      |  3 +--
 .../source/MongodbIncrementalSourceFactoryTest.java   | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java
 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java
index 170bef34e9..baf1b35aa3 100644
--- 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java
+++ 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java
@@ -241,8 +241,7 @@ public class MongodbSourceOptions extends SourceOptions {
             Options.key(SourceOptions.STARTUP_MODE_KEY)
                     .singleChoice(
                             StartupMode.class,
-                            Arrays.asList(
-                                    StartupMode.INITIAL, StartupMode.EARLIEST, 
StartupMode.LATEST))
+                            Arrays.asList(StartupMode.INITIAL, 
StartupMode.TIMESTAMP))
                     .defaultValue(StartupMode.INITIAL)
                     .withDescription(
                             "Optional startup mode for CDC source, valid 
enumerations are "
diff --git 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java
 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java
index 2269580f78..8720c7556c 100644
--- 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java
+++ 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java
@@ -17,14 +17,33 @@
 
 package mongodb.source;
 
+import org.apache.seatunnel.api.configuration.SingleChoiceOption;
+import org.apache.seatunnel.connectors.cdc.base.option.SourceOptions;
+import org.apache.seatunnel.connectors.cdc.base.option.StartupMode;
 import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.MongodbIncrementalSourceFactory;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import java.util.Arrays;
+
 public class MongodbIncrementalSourceFactoryTest {
     @Test
     public void testOptionRule() {
         Assertions.assertNotNull((new 
MongodbIncrementalSourceFactory()).optionRule());
     }
+
+    @Test
+    public void testWithUnsupportedStartUpMode() {
+        MongodbIncrementalSourceFactory mongodbIncrementalSourceFactory =
+                new MongodbIncrementalSourceFactory();
+        
mongodbIncrementalSourceFactory.optionRule().getOptionalOptions().stream()
+                .filter((option) -> 
option.key().equals(SourceOptions.STARTUP_MODE_KEY))
+                .forEach(
+                        (option) -> {
+                            Assertions.assertIterableEquals(
+                                    Arrays.asList(StartupMode.INITIAL, 
StartupMode.TIMESTAMP),
+                                    ((SingleChoiceOption<StartupMode>) 
option).getOptionValues());
+                        });
+    }
 }