Hisoka-X commented on PR #6435: URL: https://github.com/apache/seatunnel/pull/6435#issuecomment-1982247699
> > Please add test in e2e. > > Hi, please tell me the full detailed steps for "add test in e2e" since I'm fresh on this. > > Bases on my understanding, it seems that it's unnecessary to add new test cases because current test case is enoguh to cover the bug fix. As I mentioned before, we can verify the fix like below: " The fix can be tested via general windows specific flink/spark starter script. Flink: start-seatunnel-flink-13(15)-connector-v2.cmd Spark: start-seatunnel-spark-2(3)-connector-v2.cmd > > For conf file, just using the example conf file from "seatunnel_home/config" dir. v2.batch.config.template, v2.streaming.template " Oh I see. How about add some UT to verify whether the output command is right. Our UT will exeucted both on windows and linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
