liunaijie commented on code in PR #6387:
URL: https://github.com/apache/seatunnel/pull/6387#discussion_r1521194000
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/command/FlinkTaskExecuteCommand.java:
##########
@@ -48,7 +48,7 @@ public FlinkTaskExecuteCommand(FlinkCommandArgs
flinkCommandArgs) {
public void execute() throws CommandExecuteException {
Path configFile = FileUtils.getConfigPath(flinkCommandArgs);
checkConfigExist(configFile);
- Config config = ConfigBuilder.of(configFile);
+ Config config = ConfigBuilder.of(configFile,
flinkCommandArgs.getVariables());
Review Comment:
in e2e test case, this variables are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
