xiaochen-zhou commented on code in PR #6488:
URL: https://github.com/apache/seatunnel/pull/6488#discussion_r1521575814
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/config/SourceConfig.java:
##########
@@ -91,9 +93,9 @@ public SourceConfig(
.defaultValue(DEFAULT_SCAN_MEM_LIMIT)
.withDescription("Memory byte limit for a single query");
- public static final Option<String> STARROCKS_SCAN_CONFIG_PREFIX =
+ public static final Option<Map<String, String>>
STARROCKS_SCAN_CONFIG_PREFIX =
Options.key("scan.params.")
- .stringType()
+ .type(new TypeReference<Map<String, String>>() {})
.noDefaultValue()
.withDescription("The parameter of the scan data from be");
Review Comment:
> why change this? I think we should add test case for this type config.
I think we can directly set `STARROCKS_SCAN_CONFIG_PREFIX` to Map<String,
String>
, instead of setting it to String type, and then parsing it through
TypesafeConfigUtils#extractSubConfig() to get the Map<String, String> type,
and the TypesafeConfigUtils#extractSubConfig() method has been marked as
Deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
