This is an automated email from the ASF dual-hosted git repository.
zhouyao2023 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new d6dcb03bf3 [Improve][Jdbc] Support custom case-sensitive config for
dameng (#6510)
d6dcb03bf3 is described below
commit d6dcb03bf3f1a75dfd69b8bb8c08e9a63a7c1882
Author: hailin0 <[email protected]>
AuthorDate: Fri Mar 15 10:41:59 2024 +0800
[Improve][Jdbc] Support custom case-sensitive config for dameng (#6510)
---
.../jdbc/internal/dialect/dm/DmdbDialect.java | 5 +--
.../internal/dialect/dm/DmdbDialectFactory.java | 8 +++-
.../jdbc/internal/dialect/dm/DmdbDialectTest.java | 47 ++++++++++++++++++++++
3 files changed, 55 insertions(+), 5 deletions(-)
diff --git
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java
index edd51060a7..460de0272f 100644
---
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java
+++
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java
@@ -22,7 +22,6 @@ import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.converter.JdbcRow
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.DatabaseIdentifier;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialectTypeMapper;
-import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dialectenum.FieldIdeEnum;
import java.util.Arrays;
import java.util.List;
@@ -31,14 +30,12 @@ import java.util.stream.Collectors;
public class DmdbDialect implements JdbcDialect {
- public String fieldIde = FieldIdeEnum.ORIGINAL.getValue();
+ public String fieldIde;
public DmdbDialect(String fieldIde) {
this.fieldIde = fieldIde;
}
- public DmdbDialect() {}
-
@Override
public String dialectName() {
return DatabaseIdentifier.DAMENG;
diff --git
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectFactory.java
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectFactory.java
index c31d0d2b19..3d29f2f3e5 100644
---
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectFactory.java
+++
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectFactory.java
@@ -19,6 +19,7 @@ package
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dm;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialectFactory;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dialectenum.FieldIdeEnum;
import com.google.auto.service.AutoService;
@@ -33,6 +34,11 @@ public class DmdbDialectFactory implements
JdbcDialectFactory {
@Override
public JdbcDialect create() {
- return new DmdbDialect();
+ return create(null, FieldIdeEnum.ORIGINAL.getValue());
+ }
+
+ @Override
+ public JdbcDialect create(String compatibleMode, String fieldIde) {
+ return new DmdbDialect(fieldIde);
}
}
diff --git
a/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectTest.java
b/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectTest.java
new file mode 100644
index 0000000000..bc7a81f14d
--- /dev/null
+++
b/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialectTest.java
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dm;
+
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dialectenum.FieldIdeEnum;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class DmdbDialectTest {
+ @Test
+ public void testIdentifierCaseSensitive() {
+ DmdbDialectFactory factory = new DmdbDialectFactory();
+
+ JdbcDialect dialect = factory.create();
+ Assertions.assertEquals("\"test\"", dialect.quoteIdentifier("test"));
+ Assertions.assertEquals("\"TEST\"", dialect.quoteIdentifier("TEST"));
+
+ dialect = factory.create(null, FieldIdeEnum.ORIGINAL.getValue());
+ Assertions.assertEquals("\"test\"", dialect.quoteIdentifier("test"));
+ Assertions.assertEquals("\"TEST\"", dialect.quoteIdentifier("TEST"));
+
+ dialect = factory.create(null, FieldIdeEnum.LOWERCASE.getValue());
+ Assertions.assertEquals("\"test\"", dialect.quoteIdentifier("test"));
+ Assertions.assertEquals("\"test\"", dialect.quoteIdentifier("TEST"));
+
+ dialect = factory.create(null, FieldIdeEnum.UPPERCASE.getValue());
+ Assertions.assertEquals("\"TEST\"", dialect.quoteIdentifier("test"));
+ Assertions.assertEquals("\"TEST\"", dialect.quoteIdentifier("TEST"));
+ }
+}
