liunaijie commented on PR #6633: URL: https://github.com/apache/seatunnel/pull/6633#issuecomment-2033476142
> > > Seems the `canal-json` is not an incorrect word, why do we need to change it? > > > > > > https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/config/MessageFormat.java#L23 there has `canal_json` format > > is it better to edit the Enum class `MessageFormat` to keep the original names, while setting the value to `canal-json`, and compare the value later? like this, CANAL_JSON("canal-json") this is the document issue, you can see the demo config from the canal-json document and debezium-json document. they are `debezium_json` and `canal_json` instead of `debezium-json`. https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/formats/debezium-json.md?plain=1#L91 https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/formats/canal-json.md?plain=1#L98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
