Hisoka-X commented on code in PR #6635: URL: https://github.com/apache/seatunnel/pull/6635#discussion_r1554978622
########## seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-connector.cmd: ########## @@ -0,0 +1,37 @@ +@echo off +rem Licensed to the Apache Software Foundation (ASF) under one or more +rem contributor license agreements. See the NOTICE file distributed with +rem this work for additional information regarding copyright ownership. +rem The ASF licenses this file to You under the Apache License, Version 2.0 +rem (the "License"); you may not use this file except in compliance with +rem the License. You may obtain a copy of the License at +rem +rem http://www.apache.org/licenses/LICENSE-2.0 +rem +rem Unless required by applicable law or agreed to in writing, software +rem distributed under the License is distributed on an "AS IS" BASIS, +rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +rem See the License for the specific language governing permissions and +rem limitations under the License. + +setlocal enabledelayedexpansion Review Comment: Does it worked here? ########## seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/PluginDiscovery.java: ########## @@ -78,4 +81,27 @@ Optional<T> createOptionalPluginInstance( * @return plugin instances. */ List<T> getAllPlugins(List<PluginIdentifier> pluginIdentifiers); + + /** + * Get all plugins(connectors and transforms) + * + * @return + */ + default LinkedHashMap<PluginIdentifier, OptionRule> getPlugins() { + throw new UnsupportedOperationException("Not implemented"); + } + + /** Print all supported plugins(connectors and transforms) */ + default void printSupportedPlugins() { + throw new UnsupportedOperationException("Not implemented"); + } + + /** + * Print option rules of the plugin by the plugin identifier + * + * @param pluginIdentifier + */ + default void printOptionRules(String pluginIdentifier) { + throw new UnsupportedOperationException("Not implemented"); + } Review Comment: It is strange to add the printing method in the `PluginDiscovery`. It is recommended to move the printing-related logic to the Command, and the `PluginDiscovery` returns the required information. ########## seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java: ########## @@ -107,7 +113,7 @@ public AbstractPluginDiscovery( this.pluginDir = pluginDir; this.pluginMappingConfig = pluginMappingConfig; this.addURLToClassLoaderConsumer = addURLToClassLoaderConsumer; - log.info("Load {} Plugin from {}", getPluginBaseClass().getSimpleName(), pluginDir); + log.debug("Load {} Plugin from {}", getPluginBaseClass().getSimpleName(), pluginDir); Review Comment: Hi, why change this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
