EricJoy2048 commented on code in PR #6601:
URL: https://github.com/apache/seatunnel/pull/6601#discussion_r1556750716
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/TextReadStrategy.java:
##########
@@ -180,11 +176,7 @@ public void setSeaTunnelRowTypeInfo(SeaTunnelRowType
seaTunnelRowType) {
}
initFormatter();
TextDeserializationSchema.Builder builder =
- TextDeserializationSchema.builder()
- .delimiter(fieldDelimiter)
- .dateFormatter(dateFormat)
- .dateTimeFormatter(datetimeFormat)
- .timeFormatter(timeFormat);
+ TextDeserializationSchema.builder().delimiter(fieldDelimiter);
Review Comment:
> @EricJoy2048 This seems to prevent users from customizing the data format
For reading the contents of the file, the format of the custom read is
meaningless, because if the user-defined format is not consistent with the date
and time format in the file, it will fail to read, so the format must be
consistent with the content format in the file under the reading scenario.
For scenarios where a date or time is written to a file, a user-defined
format makes sense.So, I am not change the `TextWriteStrategy` code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
