Jetiaime opened a new pull request, #161:
URL: https://github.com/apache/seatunnel-web/pull/161

   ## Purpose of this pull request
   
   This PR adds the JobExecutor Delete functions. 
   
   It work like this: If the Job haven't been completed, cancel it in the 
engine, and then delete the restored conf file if it existed. Then delete it in 
the db. 
   
   I just simplely remove the record from db, and cancel the job in the engine, 
so it will not be removed if the record has been write into the sink. And I add 
some helpful functions like `isCompelete`, `jobStorePath` for simplify the 
code. The Metric Part is been repeated, I think there are some elegant ways to 
rewrite it.
   
   It's my first pr, please feel free to comment and give me some suggestion or 
advices.
   
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for 
reason:
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to